Skip to content

Update default energy rates#2207

Merged
shorowit merged 21 commits into
masterfrom
update_energy_rates
May 5, 2026
Merged

Update default energy rates#2207
shorowit merged 21 commits into
masterfrom
update_energy_rates

Conversation

@bpark1327
Copy link
Copy Markdown
Collaborator

@bpark1327 bpark1327 commented Apr 30, 2026

Pull Request Description

Closes #2194

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.sch) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@bpark1327 bpark1327 added this to the 1.12.0 milestone Apr 30, 2026
@bpark1327 bpark1327 self-assigned this Apr 30, 2026
@bpark1327 bpark1327 added the enhancement New feature or request label Apr 30, 2026
Comment thread HPXMLtoOpenStudio/resources/utility_bills.rb Outdated
@bpark1327
Copy link
Copy Markdown
Collaborator Author

@shorowit I wanted to follow up on your comment about ensuring OS-HPXML skips utility bill calculations entirely (instead of proceeding with a zero coal rate). Looking at the test case below, it seems like that behavior might already be in place. Am I interpreting that correctly?

@shorowit
Copy link
Copy Markdown
Contributor

shorowit commented May 4, 2026

@shorowit I wanted to follow up on your comment about ensuring OS-HPXML skips utility bill calculations entirely (instead of proceeding with a zero coal rate). Looking at the test case below, it seems like that behavior might already be in place. Am I interpreting that correctly?

Yes, I agree with you. Great!

@bpark1327 bpark1327 marked this pull request as ready for review May 5, 2026 19:47
@bpark1327 bpark1327 requested a review from shorowit May 5, 2026 19:47
Copy link
Copy Markdown
Contributor

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks @bpark1327! Just made a few small cleanup changes. Merging.

@shorowit shorowit merged commit adbf53a into master May 5, 2026
@github-project-automation github-project-automation Bot moved this from Triage to Done in OpenStudio-HPXML May 5, 2026
@shorowit shorowit deleted the update_energy_rates branch May 5, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update default energy rates

2 participants